Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(consensus): fix flaky TestTooFarInTheFutureProposal #768

Merged
merged 6 commits into from
Mar 20, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Mar 19, 2024

Issue being fixed or feature implemented

TestTooFarInTheFutureProposal does not test if the proposal is too much in future.

What was done?

  • refactored proposal processing in tests to allow setting proposal delivery using a middleware
  • refactored proposal-based timestamp to get more precise error description when proposal is not timely, and assert for this error in tests

How Has This Been Tested?

Run GHA tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek changed the title chore: decrease num of blocksync workers to 4 * numCPUs test(consensus): fix flaky TestTooFarInTheFutureProposal Mar 19, 2024
@lklimek lklimek marked this pull request as ready for review March 19, 2024 15:44
@lklimek lklimek enabled auto-merge (squash) March 19, 2024 15:44
@lklimek lklimek merged commit 95ead19 into v0.14-dev Mar 20, 2024
15 checks passed
@lklimek lklimek deleted the fix/flaky-blocksync-test branch March 20, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants