Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(statesync): fix flaky TestReactor_Backfill #773

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Apr 3, 2024

Issue being fixed or feature implemented

TestReactor_Backfill is flaky.

Due to some timing constraints, sometimes backfill goes as low as height 8, while it should end on height 10.
This is caused by failure testing logic effectively "delaying" some blocks at higher heights.

What was done?

  1. Added mechanism to reject blocks below 10 to the tests.
  2. Small refactoring of backfill error handling

How Has This Been Tested?

#!/bin/bash -ex

while true; do
    go test -count 1 -timeout 60s ./internal/statesync/ -test.v -run TestReactor_Backfill 2>&1 | tee log.log
    if grep -q FAIL log.log; then
        echo "Test failed, stopping."
        break
    fi
    echo "================ Test passed, running again ================"
done

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit e4c934f into v0.14-dev Apr 4, 2024
15 checks passed
@lklimek lklimek deleted the test/flaky-backfill-test branch April 4, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants