fix(mempool)!: limit mempool gossip rate on a per-peer basis

[lklimek]

Issue being fixed or feature implemented

As tx recv rate and tx send rate are global and shared by all peers. This is incorrect and not what we intended to get.

What was done?

Removed option TxRecvRatePunishPeer.
Moved rate limit logic to p2pclient.
Implemented rate limits on peer level, with garbage collector (peers not used for last 60s have their rate limits removed)

How Has This Been Tested?

1. Added unit tests for sending and receiving messages.
2. Tested on local devnet with 3 nodes, stopped core on local_1 during test to avoid consuming txs

Configuration:

local_1:

yarn dashmate config set --config local_1 platform.drive.tenderdash.mempool.txRecvRateLimit 12
yarn dashmate config set --config local_2 platform.drive.tenderdash.mempool.txSendRateLimit 10
yarn dashmate config set --config local_3 platform.drive.tenderdash.mempool.txSendRateLimit 10

yarn dashmate config set --config local_1 platform.drive.tenderdash.metrics.enabled true
yarn dashmate config set --config local_2 platform.drive.tenderdash.metrics.enabled true
yarn dashmate config set --config local_3 platform.drive.tenderdash.metrics.enabled true

yarn dashmate config set --config local_1 platform.drive.tenderdash.metrics.host 0.0.0.0
yarn dashmate config set --config local_2 platform.drive.tenderdash.metrics.host 0.0.0.0
yarn dashmate config set --config local_3 platform.drive.tenderdash.metrics.host 0.0.0.0

yarn dashmate config render --config local_1
yarn dashmate config render --config local_2
yarn dashmate config render --config local_3

yarn dashmate restart --config local_1 --platform -v
yarn dashmate restart --config local_2 --platform -v
yarn dashmate restart --config local_3 --platform -v

Result: 300 txs/15s (20 tx/s) gossiped and added to mempool of local_1 (correct result)

After changing recv lmit to 5:

yarn dashmate config set --config local_1 platform.drive.tenderdash.mempool.txRecvRateLimit 5

gets 150/15s = 10 txs/s == what expected

Breaking Changes

tx-recv-rate-punish-peer config option was removed.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

[shumkov]

👍