Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): detect quorum hash mismatch when verifying commit #791

Merged
merged 2 commits into from
May 20, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented May 20, 2024

Issue being fixed or feature implemented

If commit is created with a different quorum than it's verified, we don't have clear enough error.

What was done?

Return better error on quorum hash mismatch.

How Has This Been Tested?

GHA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek enabled auto-merge (squash) May 20, 2024 13:36
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit 991f9bc into v0.14-dev May 20, 2024
15 checks passed
@lklimek lklimek deleted the chore/quorum-mismatch-error branch May 20, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants