Merge pull request #7 from formap/fix/3-order-users-ignore-casing

Case insensitive username ordering
dasilvacontin · Sep 5, 2015 · 67c7093 · 67c7093
2 parents af0227a + 24b1897
commit 67c7093
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lib/gh-sauce.js b/lib/gh-sauce.js
@@ -79,7 +79,11 @@ module.exports.dress = function (text, config) {
   var sortedIssues = _.keys(issues).sort(function (a, b) {
     return a - b
   })
-  var sortedUsernames = _.keys(users).sort()
+  var sortedUsernames = _.keys(users).sort(function (a, b) {
+    a = a.toLowerCase()
+    b = b.toLowerCase()
+    return a < b ? -1 : a > b ? 1 : 0
+  })
 
   dressed += '\n\n'
 

diff --git a/test/gh-sauce.spec.js b/test/gh-sauce.spec.js
@@ -28,11 +28,12 @@ describe('gh-sauce', function () {
     })
 
     it('should list usernames alphabetically', function () {
-      sauce.dress('fix undefined lookup by @phillipj and @dasilvacontin')
+      sauce.dress('fix undefined lookup by @phillipj, @Formap and @dasilvacontin')
       .should.equal([
-        'fix undefined lookup by [@phillipj] and [@dasilvacontin]',
+        'fix undefined lookup by [@phillipj], [@Formap] and [@dasilvacontin]',
         '',
         '[@dasilvacontin]: https://github.com/dasilvacontin',
+        '[@Formap]: https://github.com/Formap',
         '[@phillipj]: https://github.com/phillipj',
         ''
       ].join('\n'))