overwrite urls using config unless safe

dasilvacontin · Jun 15, 2015 · 79d5f94 · 79d5f94
1 parent 2a31021
commit 79d5f94
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 12 deletions.
diff --git a/lib/gh-sauce.js b/lib/gh-sauce.js
@@ -57,10 +57,6 @@ module.exports.dress = function (text, config) {
     return hash.slice(0, -1) + '[#' + issue + ']'
   })
 
-  if (_.size(issues) + _.size(users) === 0) {
-    return text
-  }
-
   dressed = _.trimRight(dressed)
   dressed = dressed.split('\n')
 

diff --git a/test/gh-sauce.spec.js b/test/gh-sauce.spec.js
@@ -18,14 +18,6 @@ describe('gh-sauce', function () {
       }).should.throw(TypeError)
     })
 
-    it('shouldn\'t change the text if there is nothing to improve', function () {
-      var text = 'nothing to enhance'
-      sauce.dress(text).should.equal(text)
-
-      text += '\n'
-      sauce.dress(text).should.equal(text)
-    })
-
     it('should enhance usernames', function () {
       sauce.dress('fix bail not running after hooks by @dasilvacontin')
       .should.equal([
@@ -137,6 +129,25 @@ describe('gh-sauce', function () {
         ].join('\n'))
       })
 
+      it('must be able to overwrite urls', function () {
+        var config = {
+          repo: 'https://github.com/dasilvacontin/gh-sauce'
+        }
+
+        sauce.dress([
+          'fixes [#27]',
+          '',
+          '[#27]: https://github.com/mochajs/mocha/issues/27',
+          ''
+        ].join('\n'), config)
+        .should.equal([
+          'fixes [#27]',
+          '',
+          '[#27]: https://github.com/dasilvacontin/gh-sauce/issues/27',
+          ''
+        ].join('\n'))
+      })
+
       it('should throw a TypeError for invalid config for `repo`', function () {
         (function () {
           var config = {