Throw error when subclass name is not a string #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,6 +16,7 @@ | |||
| var ErrorInheritor = function () {} | |||
| function SubclassError (name, BaseError, props) { | |||
| if (name === undefined) throw new Error('Name of subclass must be provided as first argument.') | |||
| if (typeof name !== 'string') throw new Error('Espected first argument to be a string in SubclassError(name, [BaseError, [props]])') | |||
There was a problem hiding this comment.
There's a typo – Espected -> Expected.
This comment is on a part of the diff that will change after the amend.
dasilvacontin
force-pushed
the
pr-comment-test
branch
2 times, most recently
from
819fbf2
to
6ae2e50
Compare
| niceStack.splice(1, 1) | ||
| niceStack[0] = name | ||
| if (message) niceStack[0] += ': ' + message | ||
| this.stack = niceStack.join('\n') |
There was a problem hiding this comment.
Comment on some part of the code that won't change after force-pushing/squash/amend.
dasilvacontin
force-pushed
the
pr-comment-test
branch
from
6ae2e50
to
ca070f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.