Replace a couple of deprecations with updated methods #21
Conversation
j-bennet
changed the title
Yes, just took care of it. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #21 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 2 2
Lines 110 110
=======================================
Hits 104 104
Misses 6 6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@jrbourbeau Linter is fixed. |
dask_deltatable/core.py
Outdated
| filter_converter = getattr( | ||
| pq, "filters_to_expression", getattr(pq, "_filters_to_expression") | ||
| ) | ||
| filter_expression = filter_converter(filter) |
There was a problem hiding this comment.
I'm guessing this is to handle a private method that has been made public in pyarrow?
I wonder if it would feel more pythonic and readable to use a try/except here and ask forgiveness not permission?
| filter_converter = getattr( | |
| pq, "filters_to_expression", getattr(pq, "_filters_to_expression") | |
| ) | |
| filter_expression = filter_converter(filter) | |
| try: | |
| filter_expression = pq._filters_to_expression(filter) | |
| except AttributeError: | |
| filter_expression = pq.filters_to_expression(filter) |
There was a problem hiding this comment.
Good point, changed.
|
Looks like uploading to codecov failed for some CI jobs. I've bumped CI to see if this was just a transient thing or not |
Minor cleanup:
DeltaTable.pyarrow_schemais deprecated_filters_to_expressionis deprecatedreturn.