Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardises dependency versions #9

Merged
merged 2 commits into from
May 26, 2023
Merged

Conversation

rajagurunath
Copy link
Collaborator

fixes the below issues. Thanks to @TomAugspurger

Please review, and let me know if you have any suggestions, Thanks :)

Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.87 ⚠️

Comparison is base (5fa93d7) 95.41% compared to head (d786f71) 94.54%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   95.41%   94.54%   -0.87%     
==========================================
  Files           2        2              
  Lines         109      110       +1     
==========================================
  Hits          104      104              
- Misses          5        6       +1     
Impacted Files Coverage Δ
dask_deltatable/core.py 94.49% <66.66%> (-0.88%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jacobtomlinson
Copy link
Collaborator

Merged main to get the fixes from #10. CI should pass now.

@jacobtomlinson jacobtomlinson merged commit cd731a9 into main May 26, 2023
20 checks passed
@jrbourbeau jrbourbeau mentioned this pull request May 30, 2023
@jacobtomlinson jacobtomlinson deleted the feature/dependency-fix branch June 5, 2023 13:29
This was referenced Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants