Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some remaining simple operations #54

Merged
merged 15 commits into from Nov 5, 2020

Conversation

nils-braun
Copy link
Collaborator

@nils-braun nils-braun commented Oct 2, 2020

Another PR for #11

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2020

Codecov Report

Merging #54 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          985      1029   +44     
  Branches       142       157   +15     
=========================================
+ Hits           985      1029   +44     
Impacted Files Coverage Δ
dask_sql/physical/rex/core/call.py 100.00% <100.00%> (ø)
dask_sql/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d95593...eefc650. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Oct 14, 2020

Codecov Report

Merging #54 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines         1187      1233   +46     
  Branches       156       171   +15     
=========================================
+ Hits          1187      1233   +46     
Impacted Files Coverage Δ
dask_sql/physical/rex/core/call.py 100.00% <100.00%> (ø)
dask_sql/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5621a95...74dd9a6. Read the comment docs.

…ime and localtime. We use localized time in all the cases so far
@nils-braun nils-braun changed the title [WIP] Remaining simple operations Some remaining simple operations Oct 14, 2020
@nils-braun nils-braun force-pushed the feature/remaining-simple-operations branch from fc8b6e3 to 74dd9a6 Compare October 14, 2020 20:57
@nils-braun nils-braun merged commit 09093ce into main Nov 5, 2020
@nils-braun nils-braun deleted the feature/remaining-simple-operations branch November 5, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants