Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input from cluster memory #68

Merged
merged 9 commits into from Nov 3, 2020
Merged

Conversation

nils-braun
Copy link
Collaborator

This PR allows to input published datasets from the cluster memory.

This means, if you have published a dataset, e.g. with a distributed client

client.publish_dataset(my_table=df)

you can now register it with

CREATE TABLE some_name WITH (location='my_table', format='memory')

and start querying it as normal.

@mrocklin
Copy link

mrocklin commented Nov 2, 2020 via email

@codecov-io
Copy link

codecov-io commented Nov 2, 2020

Codecov Report

Merging #68 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines         1196      1200    +4     
  Branches       156       157    +1     
=========================================
+ Hits          1196      1200    +4     
Impacted Files Coverage Δ
dask_sql/physical/rel/custom/create.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e22282...b354d62. Read the comment docs.

@nils-braun
Copy link
Collaborator Author

Thanks for commenting, @mrocklin (I am always amazed how fast you find out about what is going on in the ecosystem).

I am not sure if these things can be compared so easily because the context object is local to the process it is running on (or, if running a SQL server, still local to the application but can be controlled via SQL) and the published datasets are always shared among the full cluster.

@nils-braun nils-braun merged commit 194e56f into main Nov 3, 2020
@nils-braun nils-braun deleted the feature/input-from-cluster-memory branch November 3, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants