Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quoting around partition keys for Hive table inputs #834

Merged
merged 14 commits into from
Oct 5, 2022
Merged

Add quoting around partition keys for Hive table inputs #834

merged 14 commits into from
Oct 5, 2022

Conversation

randerzander
Copy link
Collaborator

@randerzander randerzander commented Oct 3, 2022 •
edited
Loading

Fixes #179
Fixes #234

@randerzander randerzander marked this pull request as draft October 3, 2022 18:35
@randerzander randerzander marked this pull request as ready for review October 4, 2022 01:14
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2022 •
edited
Loading

Codecov Report

Merging #834 (a796647) into main (607eccf) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
+ Coverage   74.88%   75.06%   +0.18%     
==========================================
  Files          71       71              
  Lines        3588     3594       +6     
  Branches      629      632       +3     
==========================================
+ Hits         2687     2698      +11     
+ Misses        771      762       -9     
- Partials      130      134       +4
Impacted Files Coverage Δ
dask_sql/input_utils/hive.py 100.00% <100.00%> (ø)
dask_sql/_version.py 34.00% <0.00%> (+1.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@randerzander randerzander changed the title Attempted fix for unquoted partition values in Hive Add quoting around partition keys for Hive table inputs Oct 4, 2022
@randerzander randerzander marked this pull request as draft October 4, 2022 17:03
@randerzander randerzander marked this pull request as ready for review October 4, 2022 18:26
ayushdg
ayushdg approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@ayushdg ayushdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm! Thanks for looking into this @randerzander

tests/integration/test_hive.py Show resolved Hide resolved
@ayushdg ayushdg merged commit 67274c0 into dask-contrib:main Oct 5, 2022
@randerzander randerzander mentioned this pull request Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushdg ayushdg ayushdg approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multiple partitions for hive not delimited correctly Dask-SQL not wrapping partition value in quotes
3 participants
@randerzander @codecov-commenter @ayushdg