Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster limit computation on persisted dataframes #837

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

ayushdg
Copy link
Collaborator

@ayushdg ayushdg commented Oct 5, 2022

This pr adds materialized slayed to the list of layers supported for a quick single partition check to compute limit.

Fixes #833

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #837 (f34536f) into main (607eccf) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
+ Coverage   74.88%   75.09%   +0.20%     
==========================================
  Files          71       71              
  Lines        3588     3589       +1     
  Branches      629      629              
==========================================
+ Hits         2687     2695       +8     
+ Misses        771      761      -10     
- Partials      130      133       +3     
Impacted Files Coverage Δ
dask_sql/physical/rel/logical/limit.py 92.85% <100.00%> (+5.05%) ⬆️
dask_sql/_version.py 34.00% <0.00%> (+1.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ayushdg ayushdg marked this pull request as ready for review October 6, 2022 15:25
@charlesbluca charlesbluca merged commit 9915cff into dask-contrib:main Oct 10, 2022
@ayushdg ayushdg deleted the bug-limit-persisted-df branch December 12, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Basic LIMIT statements require getitem calls on each partition if table is persisted (but not otherwise)
3 participants