Add replace operator #897
Merged
Add replace operator #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJar
requested review from
ayushdg,
charlesbluca and
galipremsagar
as code owners
ayushdg
requested changes
Oct 27, 2022
dask_sql/physical/rex/core/call.py
Outdated
Comment on lines
545
to
548
| if isinstance(s, str): | ||
| return s.replace(pat, repl) | ||
| elif isinstance(s, dd.Series): | ||
| return s.str.replace(pat, repl) |
There was a problem hiding this comment.
Minor suggestion: Can replace the is instance checks with something similar to this
dask-sql/dask_sql/physical/rex/core/call.py
Lines 481 to 482 in 2dfa5f7
Comment on lines
+526
to
+527
| REPLACE(a, 'r', 'l') as w, | ||
| REPLACE('Another String', 'th', 'b') as x |
There was a problem hiding this comment.
Could you also add some tests to the unit/test_call::test_string_operations unit tests. Preferable with some edge cases if possible
Codecov Report
@@ Coverage Diff @@
## main #897 +/- ##
==========================================
+ Coverage 75.20% 75.38% +0.17%
==========================================
Files 72 72
Lines 3779 3786 +7
Branches 674 675 +1
==========================================
+ Hits 2842 2854 +12
+ Misses 804 795 -9
- Partials 133 137 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ayushdg
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #895