This repository has been archived by the owner on Aug 31, 2018. It is now read-only.
Use int_ instead of int64
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, the default integer is 32-bit. So we shouldn't assume that a default integer will be cast to NumPy's `int64`. Instead we make use of NumPy's `int_`, which may be 32-bit or 64-bit depending on the platform. This should resolve the test issue on Windows.
|
Demonstration that this works on Windows in this build. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the default integer is 32-bit. So we shouldn't assume that a default integer will be cast to NumPy's
int64. Instead we make use of NumPy'sint_, which may be 32-bit or 64-bit depending on the platform. This should resolve the test issue on Windows.