-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factual correction for text in skeleton analysis blogpost #159
Comments
I should add, it's not a fatal error. The conclusion I'd drawn from that plot was "This is consistent with what we might expect, since the healthy lung is more well developed than the lung from the hernia model." which is still supported by the correct interpretation of the plot - that there is a longer end-to-end distance for most blood vessels in the healthy lung. This makes sense, as the lung with the hernia is squashed into a smaller volume than the healthy one. |
It would be better if the violin plot show was one for Alternatively, the violin plot can stay the same (showing Related: jni/skan#197 |
Update, we're taking this approach. It's the easier way out. I had a quick look at my analysis repo here and it doesn't seem super quick to re-run and generate a new plot - I'd have to find the original data and make some changes to the notebook first. |
There is a factual error in my old skeleton analysis blogpost.
The blogpost shows a violin plot of the euclidean-distance measurement from skan, and says this is the skeleton branch thickness.
That is incorrect. I misunderstood, and the error wasn't caught by Juan's otherwise excellent review (Juan is the author of the skan library).
Instead, it is correct to call this "the straight line distance from one end of the branch to the other".
Juan says:
See this comment and this comment in an image.sc forum discussion for the full context. That discussion is from last year, but I only became aware of it today.
The text was updated successfully, but these errors were encountered: