Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate finalization tasks #9

Open
jacobtomlinson opened this issue Aug 5, 2019 · 2 comments
Open

Consolidate finalization tasks #9

jacobtomlinson opened this issue Aug 5, 2019 · 2 comments
Labels
hygiene Improve code quality and reduce maintenance overhead provider/aws/ecs Cluster provider for AWS ECS

Comments

@jacobtomlinson
Copy link
Member

To be certain that we are finalizing in the correct order we could have a clean up method which finalizes everything in one place. We could weakref it from _start.
@jacobtomlinson jacobtomlinson added the provider/aws/ecs Cluster provider for AWS ECS label Aug 5, 2019
@jacobtomlinson jacobtomlinson changed the title First releaseConsolidate finalization tasks Consolidate finalization tasks Aug 5, 2019
@jacobtomlinson jacobtomlinson added the hygiene Improve code quality and reduce maintenance overhead label Aug 6, 2019
@jacobtomlinson jacobtomlinson mentioned this issue Aug 7, 2019
Open
@kylejn27
Copy link
Contributor

kylejn27 commented Aug 7, 2019

From #23

Maybe a better idea would be an explicit cluster.close() or cluster.destroy() method that a user can run to destroy all created resources.

@jacobtomlinson
Copy link
Member Author

I think cluster.close() would be appropriate.

lukaszo pushed a commit to lukaszo/dask-cloudprovider that referenced this issue Oct 12, 2023
@bchatelard
Merge pull request dask#9 from koyeb/create-pull-request/patch
87d4cba 
Changes by create-pull-request action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hygiene Improve code quality and reduce maintenance overhead provider/aws/ecs Cluster provider for AWS ECS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobtomlinson @kylejn27