Bump flake8 and black in pre-commit config and add support for 3.11 #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also had to set python version to 3.11 when building docs. It seems that everyone is upgrading to python 3.12 :) |
lukaszo
changed the title
|
@jacobtomlinson ping :) |
jacobtomlinson
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes pre-commit failure https://github.com/dask/dask-cloudprovider/actions/runs/6709474379/job/18232600682
It looks like the default python version in the action was bumped to the latest 3.12. flake8 in version
3.9.2does not work with python3.12.I've bumped the flake8 and black to the latest versions. The new black formatter removed a few empty lines.
I've also added a support for python 3.11 and preliminary support for 3.12. Before supporting 3.12 we have to wait for a new aiohttp version aio-libs/aiohttp#7675