ci: test GitHub Actions for auto-release #339
Conversation
|
@jcrist Any way we can help to get this merged in? Would be great to have a new release with all recent updates. |
| push: | ||
| branches: | ||
| - master | ||
| - auto-release |
There was a problem hiding this comment.
Do we want this to run on every merge to master? And what is the auto-release branch?
There was a problem hiding this comment.
auto-release is a branch I made in my fork. I was testing the feasibility of this auto-release workflow, so made it run on every merge to master.
There was a problem hiding this comment.
Ok sure. That will need removing before merging though.
fanshi118
force-pushed
the
auto-release
branch
from
5a4e803
to
e9bc5a0
Compare
|
@jacobtomlinson - Actually there are two parts of this workflow. One is to build the artifacts and upload them to GitHub (like here), and the other to upload the package to PyPI. The current way we set it up is to run the first part for every merge to master - that is, rebuild the artifacts for every change made to the main/production branch. The second part, upload to PyPI, will only be triggered if a new tag is pushed. Trying to tie this back to the original issue , do we not want the artifacts for this and only push releases for every new tag? |
|
@fanshi118 that makes sense. I can't comment on whether artifacts are desired on every commit to master. Perhaps @jcrist can weigh in? |
|
@fanshi118 @jacobtomlinson Is there much left to do in here? Is there anything I can help with? |
|
@aktech I think things are pretty good here. Looks like we were just blocked on the decision to push artifacts for every commit. My vote on this would be no. |
|
This is still picking up travis, so we definitely at least need to merge from recent |
|
I'll go for a merge on this and use it as a starting point to iterate from! Thank you @fanshi118! |
consideRatio
changed the title
I was testing the auto-release features using GitHub Actions, taken from this issue . Building
dask-gatewaywent okay; however, I ran into an error while runningpython build_tools/build_manylinux.pyin buildingdask-gateway-server. There seemed to be an issue with running the docker command in the script . Would be awesome to get some feedback on this!