Helm chart: update deprecated k8s resources no longer supported in k8s 1.22#420
Merged
jacobtomlinson merged 7 commits intodask:mainfrom Aug 24, 2021
Merged
Conversation
Member
|
Thanks for your efforts here @consideRatio! I'll take a look.
I'm sure this would be much appreciated! I think we would need to get a approval from a few Dask maintainers to make this happen. I'll raise it at the weekly meeting tomorrow. |
Member
jacobtomlinson
left a comment
There was a problem hiding this comment.
This generally looks great thanks!
Collaborator
Author
|
Thanks you for your review work @jacobtomlinson! 🎉 ❤️ |
TomAugspurger
approved these changes
Aug 24, 2021
Member
|
Thanks for the excellent PRs @consideRatio! You should now have write access to this repository. |
Collaborator
Author
|
Thank you @jacobtomlinson, @TomAugspurger, @jcrist! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
apiextensions.k8s.io/v1beta1toapiextensions.k8s.io/v1helm lintandhelm templateis added before the heavyweight test to build images and install the Helm chart is ranReview notes
I have been a bit cautious to put in work in this repo because I'm not sure if a PR I'd make would be reviewed -> merged given limited maintenance capacity available among dask maintainers. If it would help, I'd be very happy to take on some maintenance responsibility and issue triage/review/merge PRs related to the dask-gateway Helm chart and/or documentation in general.
I'm not sure who has rights to make decisions about these matters or can review this PR, perhaps @martindurant or @jacobtomlinson?
Thanks everyone involved for an amazing project!