-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm chart: update deprecated k8s resources no longer supported in k8s 1.22 #420
Conversation
Thanks for your efforts here @consideRatio! I'll take a look.
I'm sure this would be much appreciated! I think we would need to get a approval from a few Dask maintainers to make this happen. I'll raise it at the weekly meeting tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks great thanks!
Thanks you for your review work @jacobtomlinson! 🎉 ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this Erik. I'll let Jacob comment on the CI approach. I'm fine with either (and the experience from jupyterhub is very helpful.).
Thanks for the excellent PRs @consideRatio! You should now have write access to this repository. |
Thank you @jacobtomlinson, @TomAugspurger, @jcrist! 🎉 |
PR summary
apiextensions.k8s.io/v1beta1
toapiextensions.k8s.io/v1
helm lint
andhelm template
is added before the heavyweight test to build images and install the Helm chart is ranReview notes
I have been a bit cautious to put in work in this repo because I'm not sure if a PR I'd make would be reviewed -> merged given limited maintenance capacity available among dask maintainers. If it would help, I'd be very happy to take on some maintenance responsibility and issue triage/review/merge PRs related to the dask-gateway Helm chart and/or documentation in general.
I'm not sure who has rights to make decisions about these matters or can review this PR, perhaps @martindurant or @jacobtomlinson?
Thanks everyone involved for an amazing project!