Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart: update deprecated k8s resources no longer supported in k8s 1.22 #420

Merged
merged 7 commits into from
Aug 24, 2021

Conversation

consideRatio
Copy link
Collaborator

@consideRatio consideRatio commented Aug 21, 2021

PR summary

Review notes

I have been a bit cautious to put in work in this repo because I'm not sure if a PR I'd make would be reviewed -> merged given limited maintenance capacity available among dask maintainers. If it would help, I'd be very happy to take on some maintenance responsibility and issue triage/review/merge PRs related to the dask-gateway Helm chart and/or documentation in general.

I'm not sure who has rights to make decisions about these matters or can review this PR, perhaps @martindurant or @jacobtomlinson?

Thanks everyone involved for an amazing project!

@jacobtomlinson
Copy link
Member

Thanks for your efforts here @consideRatio! I'll take a look.

I'd be very happy to take on some maintenance responsibility and issue triage/review/merge PRs related to the dask-gateway Helm chart and/or documentation in general.

I'm sure this would be much appreciated! I think we would need to get a approval from a few Dask maintainers to make this happen. I'll raise it at the weekly meeting tomorrow.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks great thanks!

@consideRatio
Copy link
Collaborator Author

Thanks you for your review work @jacobtomlinson! 🎉 ❤️

Copy link
Member

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this Erik. I'll let Jacob comment on the CI approach. I'm fine with either (and the experience from jupyterhub is very helpful.).

@jacobtomlinson jacobtomlinson merged commit 1dfa7f1 into dask:main Aug 24, 2021
@jcrist
Copy link
Member

jcrist commented Aug 24, 2021

Thanks for the excellent PRs @consideRatio! You should now have write access to this repository.

@consideRatio
Copy link
Collaborator Author

Thank you @jacobtomlinson, @TomAugspurger, @jcrist! 🎉

@consideRatio consideRatio deleted the pr/api-versions branch March 25, 2022 01:15
@consideRatio consideRatio added bug Something isn't working maintenance and removed bug Something isn't working labels Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart: transition apiextensions.k8s.io/v1beta1 to v1 (required for use with k8s 1.22)
4 participants