No longer explicitly set imagePullPolicy to IfNotPresent by default - #770
Merged
Merged
Conversation
consideRatio
requested review from
TomAugspurger,
jacobtomlinson and
martindurant
November 17, 2023 12:16
Collaborator
Author
|
Thank you for reviewing @TomAugspurger!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is inspired by jupyterhub/kubespawner#807.
This PR influences the specific situation when a
latesttagged image is to be used, then omiting the imagePullPolicy will result in a changed behavior to instead act as if imagePullPolicy was specified toAlways. For any other image tag, omittingimagePullPolicystill behaves as if its set toIfNotPresent.