New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the input argument to image in the ndimage functions #117
Rename the input argument to image in the ndimage functions #117
Conversation
This is great! 😄 We also need to change the |
@GenevieveBuckley sure, it sounds fun. I will give it a shot! |
FYI: I'm to integrating the changes we made to our CI builds (so we can see the tests pass on your branch). I might also merge this in soon, and leave the |
🎉 Yay, merged! 🎉 |
Thanks @akhalighi for working on this and @GenevieveBuckley for the review! |
Also just realized I hadn't opened the SciPy issue about renaming |
This PR implements the following:
The wrappers for functions ported from
scipy.ndimage
are modified to rename theinput
argument toimage
.The
_get_docstring
utility function forfilters
is modified to:input
keyword withimage
when porting docstrings.Examples
from the original docstring inscipy.ndimage
since they most probably will be invalid for thedask-image
wrappers.Contributes to #101