Skip to content

Commit

Permalink
Tell pytest to fail fast (#772)
Browse files Browse the repository at this point in the history
* Tell pytest to fail fast

* Superficial change to trigger CI

* Don't wait for CRD cleanup
  • Loading branch information
jacobtomlinson committed Jul 24, 2023
1 parent 0cd5def commit 2c48b6e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/operator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,6 @@ jobs:
TEST_ISTIO: "true"
TEST_DASK_GATEWAY: "true"
run: pytest dask_kubernetes/common dask_kubernetes/operator dask_kubernetes/aiopykube
- name: Debug k8s resources
- name: Debug kubernetes resources
if: always()
run: kubectl get all -A
3 changes: 1 addition & 2 deletions dask_kubernetes/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ def install_gateway(k8s_cluster):

@pytest.fixture(scope="session", autouse=True)
def customresources(k8s_cluster):

temp_dir = tempfile.TemporaryDirectory()
crd_path = os.path.join(DIR, "operator", "customresources")

Expand All @@ -127,5 +126,5 @@ def run_generate(crd_path, patch_path, temp_path):

k8s_cluster.kubectl("apply", "-f", temp_dir.name)
yield
k8s_cluster.kubectl("delete", "-f", temp_dir.name)
k8s_cluster.kubectl("delete", "--wait=false", "-f", temp_dir.name)
temp_dir.cleanup()
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ tag_prefix =
parentdir_prefix = dask-kubernetes-

[tool:pytest]
addopts = -v --keep-cluster --durations=10
addopts = -v -x --keep-cluster --durations=10
timeout = 60
timeout_func_only = true
reruns = 3
Expand Down

0 comments on commit 2c48b6e

Please sign in to comment.