Skip to content

Commit

Permalink
Implement new container env mechanism also for Dask Jobs (#879)
Browse files Browse the repository at this point in the history
* Implement new container env mechanism also for Dask Jobs

* Black fixes

---------

Co-authored-by: Jonas Dedden <jonas.dedden@deepl.com>
  • Loading branch information
jonded94 and Jonas Dedden committed Apr 3, 2024
1 parent 93fe171 commit d3f0ef8
Showing 1 changed file with 12 additions and 10 deletions.
22 changes: 12 additions & 10 deletions dask_kubernetes/operator/controller/controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,17 +197,19 @@ def build_job_pod_spec(job_name, cluster_name, namespace, spec, annotations, lab
},
"spec": copy.deepcopy(spec),
}
env = [
{
"name": "DASK_SCHEDULER_ADDRESS",
"value": f"tcp://{cluster_name}-scheduler.{namespace}.svc.cluster.local:8786",
},
]
scheduler_env = {
"name": "DASK_SCHEDULER_ADDRESS",
"value": f"tcp://{cluster_name}-scheduler.{namespace}.svc.cluster.local:8786",
}
for container in pod_spec["spec"]["containers"]:
if "env" in container:
container["env"].extend(env)
else:
container["env"] = env
if "env" not in container:
container["env"] = [scheduler_env]
continue

container_env_names = [env_item["name"] for env_item in container["env"]]

if "DASK_SCHEDULER_ADDRESS" not in container_env_names:
container["env"].append(scheduler_env)
return pod_spec


Expand Down

0 comments on commit d3f0ef8

Please sign in to comment.