Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Add keyword for match_node_purpose #164

Conversation

TomAugspurger
Copy link
Member

@TomAugspurger
Copy link
Member Author

cc @jhamman @scottyhq

@jacobtomlinson
Copy link
Member

Looks like this has some merge conflicts after the big refactor in #162. @TomAugspurger are you ok to resolve those?

Sorry!

@scottyhq
Copy link

I think updating or merging this would be helpful (see pangeo-data/pangeo-cloud-federation#567). @TomAugspurger can you give an example of how users can select this setting in dask_cofig.yaml or elsewhere?

For example in JupyterHub values.yaml we can set:

  jupyterhub:
    scheduling:
      userPods:
        nodeAffinity:
          matchNodePurpose: prefer
      corePods:
        nodeAffinity:
          matchNodePurpose: require

@TomAugspurger
Copy link
Member Author

TomAugspurger commented Mar 23, 2020 via email

@jacobtomlinson
Copy link
Member

Thanks @TomAugspurger. Not sure what worked as CI is failing.

@jacobtomlinson
Copy link
Member

Thanks @TomAugspurger. CI seems to be failing now. Could you take a look?

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like clean_pod_spec is not a valid fixture?

@@ -7,6 +7,7 @@ kubernetes:
host: "0.0.0.0"
port: 0
env: {}
match_node_purpose: "prefer"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be better as match-node-purpose

Base automatically changed from master to main March 8, 2021 15:34
@jacobtomlinson
Copy link
Member

I am going to close this out as it is rather old and I think the Pangeo folks have moved to `dask-gateway anyway.

Sorry this got dropped. Feel free to ping here if it still has value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dask workers can be scheduled on hub pods with default config
4 participants