Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique colors to "Workers", "Task Stream" etc buttons or reorganize to more easily find each #179

Open
kpasko opened this issue Mar 18, 2021 · 9 comments

Comments

@kpasko
Copy link

kpasko commented Mar 18, 2021

Since the arrangement shifts depending on the size of the jupyterlab window, it is often difficult to locate a particular view/tab. Adding a unique color, (e.g. "Progress" is always teal, "Profile" is always purple, and the like) or some other disambiguation would be a nice addition.

@jrbourbeau
Copy link
Member

@kpasko is the order always the same? I.e. "Progress" is the fix button, "Task stream" is the second button, etc.

@kpasko
Copy link
Author

kpasko commented Mar 18, 2021

Sadly no, the ordering is different each time

@jrbourbeau
Copy link
Member

Maybe keeping the same order would solve the "where is the X plot?" issue

@ian-r-rose
Copy link
Collaborator

We get the list of charts from individual-plots.json endpoint in the distributed dashboard. They are given as an unordered JSON object, but we could sort the keys before displaying them.

Since different spins of the dashboard might expose different dashboard charts, it's tough to assign predictable button colors in full generality here. We could add a suggested color field in distributed, though (perhaps selecting from the dask brand colors?) and pick them up when rendering the options

@kpasko
Copy link
Author

kpasko commented Mar 18, 2021

Would help, although I still thing a visual cue would be nice if laid out as-is.

locating "6" in an m x n grid where both m and n can change is still not always straightforward.

If they were consistent and simply displayed as a vertical list (a la files / terminals tabs) that would do it.

color is just a cognitive thing of "okay i always click red, blue, and brown", but i understand your point about staying consistent when different flavors roll out

@mrocklin
Copy link
Member

+1 on sort order, which should be easy.

We could do colors, maybe by theme. Memory-related plots could be darker orange, processing-related plots could be lighter orange, etc.. I agree that this is a decision that we would want to make on the dask/distributed side.

Alternatively, maybe we should zoom out a bit and ask what the right way to lay out these choices is. The "field of buttons" choice made sense early on, but may no longer make sense. Does anyone have any thoughts for alternative ways to provide these options?

@mrocklin
Copy link
Member

Maybe something more like the vanilla JLab menu would make more sense

image

@kpasko
Copy link
Author

kpasko commented Jul 18, 2021 via email

@mrocklin
Copy link
Member

mrocklin commented Jul 18, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants