Serverextension #31
Merged
Serverextension #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cluster management component.
a display name to the model.
|
I've had some difficulty in setting this up. Help would be appreciated.
|
|
As far as I can tell, you have not installed the client-side part of the extension. From the root of the repository jlpm install
jlpm build
jupyter labextension install .With a server extension the install story for users is going to be a bit more complicated (though we can talk through some steps to mitigate that), so we had better make it worth while :) |
|
OK, I run the following: Things show up nicely in JLab, but pressing the "new cluster" button results in a 404 |
|
Hmm. Does |
|
When I enter |
|
|
Hm, I see |
|
That works. Everything seems pretty slick to me so far. I'll take a look at the web server side code next. |
ian-r-rose
force-pushed
the
serverextension
branch
from
f4464cd
to
5e52a9e
Compare
|
@jhamman, this is close-to-ready for another round of testing. I know you have a bunch of free time at AGU! |
|
@ian-r-rose - took this for a spin today. Really liking where its heading. One thing, I think its still not obvious that the user needs to right click to insert the code cell. Can we make this a link/button on the cluster section in the extension? |
|
@jhamman, good point. I've added another button to the cluster listing for injecting the client code. I've also fleshed out the context menu a bit, so the user can manipulate clusters using either avenue. |
|
Exciting work!! 👍 I ended up here after trying to use the extension to access a dashboard not accessible through the internet but only from within the network that the jupyter server is running. |
|
@ian-r-rose - I'm happy here for now. Is there more you'd like to sneak in here? |
|
I think this is ready from my perspective. Thanks for putting it through the paces @jhamman! |
|
Okay @mrocklin, I think this is just about ready. I'm sure stuff is busy right now, but if you get the chance to take this for a spin... |
|
Spin taken. In general I think it looks great. The only-speedbump I ran into was not knowing immediately how to connect a notebook to it. The I'd be more than happy to merge this in now though if you'd like to move on. I think that users will be able to figure that out. |
|
We could certainly change it to This PR is getting pretty big as it is, so I think having more refinements in follow-ups is a good idea. If you are happy, I'd say merge away! |
|
I'll give @jhamman an hour to look things over, and then plan to merge afterwards. |
|
This is in. Thanks @ian-r-rose . Should we release? |
|
Can we merge without squashing? This is a big PR and represents a lot of work, and most of the commits have semantic meaning. |
|
Ah, my apologies. I just squash-and-release by default these days. It's been soon enough that rewriting history seems reasonable to me. Care to just force push to master? |
|
Sure, thanks! |
Merged
|
@mrocklin can you add me as a maintainer of the |
|
Sure, what is your PyPI username?
…On Mon, Dec 17, 2018 at 2:55 PM Ian Rose ***@***.***> wrote:
@mrocklin <https://github.com/mrocklin> can you add me as a maintainer of
the dask-labextension package on PyPI?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASszLbqLJAOes1UtMmFYJ9mvQj9vB6Zks5u5_bNgaJpZM4YKKyT>
.
|
|
Username |
|
Done
…On Mon, Dec 17, 2018 at 3:47 PM Ian Rose ***@***.***> wrote:
Username irose
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASszI_z8fRODIlSkMia6B9orVJKZFP0ks5u6ALcgaJpZM4YKKyT>
.
|
|
Thanks @ian-r-rose! |
|
Okay, published with server extension |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is more to do, but this is getting big enough as it is, so I'd prefer to do it in follow-up PRs. This creates a server extension for managing dask clusters. It allows you to list, start and stop them via a REST api. A UI for this is implemented in the side panel. You can also inject code to connect to any of the clusters via right-clicking on their list item
TODOS.