Replace internal fork of nbserverproxy with jupyter-server-proxy #58
Conversation
|
The idea is that when a new cluster gets created, we register a new tornado handler returned by make_dashboard_handler. We can unregister it when cluster is deleted. This also lets us use cluster names rather than IDs if needed, and remove state that is matching cluster IDs with clusters. |
|
@ian-r-rose I also haven't actually tested this :D But it should work, and I copy pasted this code from another project I just did... |
|
One thing I was at least trying to leave the door open to was dashboard servers that were running other places than |
|
Nope it should be fine. We can make that configurable as the next step. |
|
FYI @quasiben . Nothing for you to do here, but wanted to make you aware
of the jupyter-server-proxy and how it's used in dask-labextension.
…On Fri, Apr 26, 2019 at 8:59 PM Yuvi Panda ***@***.***> wrote:
Nope it should be fine. We can make that configurable as the next step.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACKZTDA6ARXNYUUBXBYVHLPSOXQZANCNFSM4HI3B55Q>
.
|
|
👍
On Sat, Apr 27, 2019, 10:01 AM Matthew Rocklin <notifications@github.com>
wrote:
… FYI @quasiben . Nothing for you to do here, but wanted to make you aware
of the jupyter-server-proxy and how it's used in dask-labextension.
On Fri, Apr 26, 2019 at 8:59 PM Yuvi Panda ***@***.***>
wrote:
> Nope it should be fine. We can make that configurable as the next step.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <
#58 (comment)>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AACKZTDA6ARXNYUUBXBYVHLPSOXQZANCNFSM4HI3B55Q
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKWW6DMCVJJYZ4CTLH45V3PSRMB3ANCNFSM4HI3B55Q>
.
|
|
Fixes #49. cc @jakirkham |
|
NB: My current distributed setup has a remote scheduler/dashboard. I am in the process of moving to k8s though but IIUC there are plans to allows remote schedulers there too |
|
Thanks for the info @dhirschfeld. @yuvipanda, sounds like we should move remote-server proxying towards the front-burner. |
|
No need to rush on my account - it's just something to keep in mind. xref: dask/dask-kubernetes#84 |
be remote. Assumes that the remote dashboard is a trusted source to be iframed.
|
Okay, this should be good to go from my end. @dhirschfeld I think this should continue working with your remote dashboard setup, but let us know if there are any troubles. |
ian-r-rose
changed the title
|
Moving forwards with this. Thanks @yuvipanda! |
|
Thanks so much all for working on this! 😄 |
No description provided.