Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make regression metrics 'multioutput' behavior consistent with scikit-learn (fixes #818) #820

Merged
merged 3 commits into from
Apr 10, 2021
Merged

make regression metrics 'multioutput' behavior consistent with scikit-learn (fixes #818) #820

merged 3 commits into from
Apr 10, 2021

Conversation

jameslamb
Copy link
Member

Fixes #818.
Fixes #819.

Changes in this PR

  • ensures that regression metrics respect compute argument when multioutput == "raw_values"
  • ensures that regression metrics' treatment of multioutput=None matches the behavior of their scikit-learn equivalents
  • removes irrelevant comment about np.average() in regression metrics
  • adds tests on behavior of metrics for different values of multioutput

Background

See the linked issues for an explanation. I believe this PR is worth accepting because it will resolve an inconsistency with scikit-learn and with dask-ml itself, but it is technically a breaking change.

Thanks for your time and consideration.

Copy link
Member

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that the old behavior was incorrect. Thanks for the fix.

@TomAugspurger TomAugspurger merged commit db2e7d5 into dask:main Apr 10, 2021
@jameslamb jameslamb deleted the fix/series-metrics branch April 10, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants