Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make 'jupyter-server-proxy' an optional install #102

Merged
merged 3 commits into from
Apr 6, 2023
Merged

make 'jupyter-server-proxy' an optional install #102

merged 3 commits into from
Apr 6, 2023

Conversation

mgeplf
Copy link
Contributor

@mgeplf mgeplf commented Apr 4, 2023

No description provided.

@mgeplf
Copy link
Contributor Author

mgeplf commented Apr 4, 2023

As far as I can tell, jupyter-server-proxy is not a needed dependency; however it may be useful for debugging. Since it is an 'extra', it would be nice to make it optional.
This way, jupyter and it's dependencies aren't installed.

@kmpaul
Copy link
Collaborator

kmpaul commented Apr 4, 2023

I think that's fair. Thanks for the PR!

@mgeplf
Copy link
Contributor Author

mgeplf commented Apr 4, 2023

No problem; thanks for the quick response.

If it can be removed altogether, that works too. IIRC, dask or distributed print a banner saying it can be installed if visualization is desired.

@kmpaul
Copy link
Collaborator

kmpaul commented Apr 5, 2023

If Dask and distributed print a banner, and it is optional for them, it's ok to remove it.

@mgeplf
Copy link
Contributor Author

mgeplf commented Apr 5, 2023

I just checked:
distributed doesn't include it in its requirements: https://github.com/dask/distributed/blob/main/pyproject.toml#L28

The dask scheduler prints this message, on startup:

2023-04-05 08:55:35,419 - distributed.http.proxy - INFO - To route to workers diagnostics web server please install jupyter-server-proxy: python -m pip install jupyter-server-proxy

I have pushed a change that removes jupyter-server-proxy completely.

mgeplf added a commit to mgeplf/spack that referenced this pull request Apr 5, 2023
@mgeplf
py-dask-mpi: remove jupyter-server-proxy
fcc8a8d 
This dependency isn't a 'hard' one; it optionally simplifies getting access to the web consoles.
See: dask/dask-mpi#102
@kmpaul
Copy link
Collaborator

kmpaul commented Apr 5, 2023

Is it ready to merge then?

@mgeplf
Copy link
Contributor Author

mgeplf commented Apr 5, 2023

Is it ready to merge then?

Yup, I think so.

@kmpaul
Copy link
Collaborator

kmpaul commented Apr 6, 2023

Thanks so much for the PR!

@kmpaul kmpaul merged commit be54931 into dask:main Apr 6, 2023
5 checks passed
@mgeplf mgeplf mentioned this pull request Apr 6, 2023
Merged
@mgeplf
Copy link
Contributor Author

mgeplf commented Apr 6, 2023

Thanks so much for the PR!

No problem, thanks for accepting it, and maintaining dask-mpi.

@mgeplf mgeplf deleted the optional-jupyter-proxy branch April 6, 2023 15:56
adamjstewart pushed a commit to spack/spack that referenced this pull request Apr 14, 2023
@mgeplf
py-dask-mpi: remove jupyter-server-proxy (#36680)
f171d7e 
* py-dask-mpi: remove jupyter-server-proxy

This dependency isn't a 'hard' one; it optionally simplifies getting access to the web consoles.
See: dask/dask-mpi#102

* Add patch to remove unnecessary dependency

* review comments

* pass formatting
mgeplf added a commit to BlueBrain/spack that referenced this pull request Apr 14, 2023
@mgeplf
py-dask-mpi: remove jupyter-server-proxy (spack#36680)
bd7fe37 
* py-dask-mpi: remove jupyter-server-proxy

This dependency isn't a 'hard' one; it optionally simplifies getting access to the web consoles.
See: dask/dask-mpi#102

* Add patch to remove unnecessary dependency

* review comments

* pass formatting
@mgeplf mgeplf mentioned this pull request Apr 14, 2023
Merged
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Apr 25, 2023
@mgeplf @RikkiButler20
py-dask-mpi: remove jupyter-server-proxy (spack#36680)
bf31696 
* py-dask-mpi: remove jupyter-server-proxy

This dependency isn't a 'hard' one; it optionally simplifies getting access to the web consoles.
See: dask/dask-mpi#102

* Add patch to remove unnecessary dependency

* review comments

* pass formatting
mgeplf added a commit to BlueBrain/spack that referenced this pull request Jun 9, 2023
@mgeplf
py-dask-mpi: remove jupyter-server-proxy (spack#36680)
5cd5362 
* py-dask-mpi: remove jupyter-server-proxy

This dependency isn't a 'hard' one; it optionally simplifies getting access to the web consoles.
See: dask/dask-mpi#102

* Add patch to remove unnecessary dependency

* review comments

* pass formatting
mgeplf added a commit to BlueBrain/spack that referenced this pull request Jun 9, 2023
@mgeplf
py-dask-mpi: remove jupyter-server-proxy (spack#36680) (#1962)
e582cb9 
* py-dask-mpi: remove jupyter-server-proxy

This dependency isn't a 'hard' one; it optionally simplifies getting access to the web consoles.
See: dask/dask-mpi#102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mgeplf @kmpaul