Reinstate scheduler port CLI option #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of the errors in this PR are related to the bug found in #74. |
|
@jacobtomlinson: With #77, some of these tests might pass. Can you try pulling changes into your PR? |
|
@jacobtomlinson: Ok. I pushed some changes to your branch...just because I could. The tests pass. Is this ready to merge? |
|
I'm going to merge this. Thanks for getting this started, @jacobtomlinson! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the
--scheduler-portflag is passed to theSchedulerobject.There also appears to be a test that checks this but was skipped as it was undecided whether or not the worker and nanny ports should be confiruable. For now I've removed the worker/nanny checks from the tests and removed the skip.
Closes #72.