Use a lighter background color #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find true black to be hard to look at, and find the crisp borders between the menu/navbar and the lighter content distracting. Softening the color to a dark grey seems to make things easier to look at IMO. Many designers also agree: - https://ianstormtaylor.com/design-tip-never-use-black/ - https://uxmovement.com/content/why-you-should-never-use-pure-black-for-text-or-backgrounds/ - https://graphicdesign.stackexchange.com/questions/25356/why-not-use-pure-black-000-and-pure-white-fff
|
Docs page:
Main page (would need to be a PR in separate repo):
|
|
cc @mrocklin, @jrbourbeau, @jacobtomlinson (y'all were involved in a previous discussion on this). |
|
Thanks for taking this on @jcrist ! I'm just happy to have others make decisions here :) |
jrbourbeau
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
LGTM! Thanks @jcrist for providing these changes and background material
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find true black to be hard to look at, and find the crisp borders
between the menu/navbar and the lighter content distracting. Softening
the color to a dark grey seems to make things easier to look at IMO.
Many designers also agree: