Skip to content

Commit

Permalink
Fix flaky test on python 2.7
Browse files Browse the repository at this point in the history
Something is killing the skein daemon between tests on python 2.7 only.
I've determined it's not a bug in:
- Skein (close/del is implemented properly and tested in skein)
- dask-yarn (finalizers aren't being called)
- py.test (daemon persists between tests if dask isn't used)

It may be a weird interaction between py.test and signal handling that
distributed/tornado sets up, idk. Since python 2.7 is going away
shortly, I'm just going to punt on this. For now we just create a new
client for each test and things work fine.
  • Loading branch information
jcrist committed Oct 26, 2018
1 parent 2422ba8 commit ffad522
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dask_yarn/tests/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def conda_env():
return envpath


@pytest.fixture(scope='module')
@pytest.fixture
def skein_client():
with skein.Client() as client:
yield client
Expand Down

0 comments on commit ffad522

Please sign in to comment.