Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new HTTP error for aiohttp #6433

Closed
martindurant opened this issue Jul 21, 2020 · 3 comments
Closed

new HTTP error for aiohttp #6433

martindurant opened this issue Jul 21, 2020 · 3 comments

Comments

@martindurant
Copy link
Member

Since HTTPFileSystem now uses aiohttp, the exception has changed, such that the test dask/bytes/tests/test_http.py::test_errors fails: instead of requests.exceptions.RequestException, you get a aiohttp.client_exceptions.ClientResponseError. This could be fixed in the test, but one might argue that fsspec should return a FileNotFoundError instead.
@martindurant
Copy link
Member Author

^ this is in fsspec master, not yet released

@gforsyth
Copy link
Contributor

Are there other likely/common causes of aiohttp.client_exceptions.ClientResponseError besides not finding a target file (within the fsspec usage)? If not, I would be in favor of a FileNotFoundError

@martindurant
Copy link
Member Author

The exception instance in the test contains the 404 explicitly, but there are probably other causes like various connection things (proxy...) and the full set of HTTP error codes.

martindurant pushed a commit to martindurant/dask that referenced this issue Jul 22, 2020
Copes with fsspec switching requests -> aiohttp
7f91449 
Fixes dask#6433
kumarprabhu1988 pushed a commit to kumarprabhu1988/dask that referenced this issue Oct 29, 2020
@martindurant @kumarprabhu1988
HTTP error for new fsspec (dask#6446)
86864b9 
* Copes with fsspec switching requests -> aiohttp

Fixes dask#6433

* black

* Add aiohttp to dev envs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gforsyth @martindurant