-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Column assignments fails with Float64Dtype type #7156
Comments
I think the solution that you propose is very reasonable and if you are willing to open a PR even better! Just as a heads up there is a release planned for friday (tomorrow) so it'd be great to get this in. |
nils-braun
added a commit
to nils-braun/dask
that referenced
this issue
Feb 4, 2021
3 tasks
@jsignell PR is open - I hope it was still on time yesterday evening (European time) |
jsignell
pushed a commit
that referenced
this issue
Feb 5, 2021
* Added support for Float64, solving #7156 * Early exit on older pandas versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened:
When using pandas' new Float64 nullable type (with pandas >= 1.2), column assignment fails with
Minimal Complete Verifiable Example:
Fails at least with pandas version 1.2.0 (below that, the new extension type was not introduced).
Full stacktrace
As a fix, I guess one wants to introduce a function similar to https://github.com/dask/dask/blob/master/dask/dataframe/utils.py#L43 (but for floats) and use it in https://github.com/dask/dask/blob/master/dask/dataframe/utils.py#L540. I am happy to open a PR to fix this if this solution is ok.
Environment:
The text was updated successfully, but these errors were encountered: