Warn consistently for inplace in Series.rename
#10313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
reviewed
May 31, 2023
There was a problem hiding this comment.
Thanks @phofl
Can we safely remove the
warnings.warn(
"'inplace' argument for dask series will be removed in future versions",
PendingDeprecationWarning,
)a few lines below now?
dask/dataframe/core.py
Outdated
| if inplace is not no_default: | ||
| warnings.warn( | ||
| "'inplace' argument for dask series will be removed in future versions", | ||
| PendingDeprecationWarning, |
There was a problem hiding this comment.
I'm not sure why PendingDeprecationWarning was used originally. Probably worth upgrading to FutureWarning
|
Yep good point, removed |
hendrikmakait
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
Thanks, @phofl! This looks good to me, and all of @jrbourbeau's concerns seem to have been addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous warning seemed very inconsistent