Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore numba in upstream build #10330

Merged
merged 2 commits into from Jun 12, 2023
Merged

Restore numba in upstream build #10330

merged 2 commits into from Jun 12, 2023

Conversation

jrbourbeau
Copy link
Member

numba/numba#8615 is closed, so let's see if the upstream build works with numba included now

@jrbourbeau
Copy link
Member Author

Hmm so upstream is failing but for reasons unrelated to the changes here. I see the same failure on main

@jrbourbeau
Copy link
Member Author

The upstream build is failing, but it's the same failures we're already seeing on main (xref #10347). So unrelated to the changes in this PR

ncclementi
ncclementi approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@ncclementi ncclementi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James LGTM

@jrbourbeau jrbourbeau merged commit 3b84f31 into dask:main Jun 12, 2023
20 of 24 checks passed
@jrbourbeau jrbourbeau deleted the reinclude-numba-upstream branch June 12, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncclementi ncclementi ncclementi approved these changes

Assignees
No one assigned
Labels
upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrbourbeau @ncclementi