concat ignoring DataFrame withouth columns
#10359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-bennet
reviewed
Jun 22, 2023
| if axis == 1: | ||
| try: | ||
| # remove any empty DataFrames | ||
| dfs = [df for df in dfs if bool(len(df.columns))] |
There was a problem hiding this comment.
In PR description, you mention that:
we should keep DataFrames with no columns but an Index"
This code doesn't seem to be doing it, and I don't see a test case for it. Can you clarify?
There was a problem hiding this comment.
I forgot one important part:
we should keep DataFrames with no columns but an Index for axis=0
Reason is simple: Consistency with pandas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesWe found this in dask-expr. The check was implemented to ignore completely empty DataFrames, since it would coerce ints to floats, but we should keep DataFrames with no columns but an Index