Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_first_and_last to accommodate deprecated last #10373

Merged
merged 2 commits into from Jun 30, 2023
Merged

Fix test_first_and_last to accommodate deprecated last #10373

merged 2 commits into from Jun 30, 2023

Conversation

jrbourbeau
Copy link
Member

This fixes

FAILED dask/dataframe/tests/test_dataframe.py::test_first_and_last[last] - FutureWarning: last is deprecated and will be removed in a future version. Please create a mask and filter using `.loc` instead

which we're currently seeing in the upstream build (xref #10347).

Note that we were already emitting a FutureWarning for DataFrame.last, so this is a tests-only PR

cc @j-bennet @phofl

phofl
phofl approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jrbourbeau jrbourbeau merged commit 9203599 into dask:main Jun 30, 2023
23 of 24 checks passed
@jrbourbeau jrbourbeau deleted the last-deprecated-test branch June 30, 2023 22:41
j-bennet pushed a commit to j-bennet/dask that referenced this pull request Jul 28, 2023
@jrbourbeau @j-bennet
Fix test_first_and_last to accommodate deprecated last (dask#…
79fcbfa 
…10373)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
dataframe upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrbourbeau @phofl