Fix ValueError when running to_csv in append mode with single_file as True #10441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? Admins can comment |
|
add to allowlist |
Co-authored-by: Hendrik Makait <hendrik@makait.com>
Co-authored-by: Hendrik Makait <hendrik@makait.com>
Co-authored-by: Hendrik Makait <hendrik@makait.com>
hendrikmakait
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
The updated test looks great. Thanks for your contribution, @benrutter!
|
I've committed two minor nit-picks and will merge once CI is done. |
3 tasks
|
I think the failing test here isn't related to this PR? (it's from dask/dataframe/io/tests/test_parquet.py) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesI think this is pretty well described here: #10414
Currently dask adds on "a" to the mode when single_file is True, but this clashes when the mode is already set to "a".
This PR adds in a conditional check the the mode ending with "a" before appending "a" to the end.
Also, testing added to cover the bug fix.