Skip failing tests for pandas=2.1.0
#10488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
reviewed
Sep 1, 2023
| @@ -130,8 +129,7 @@ def _write_partitioned( | |||
|
|
|||
| md_list = [] | |||
| partition_keys = partition_keys[0] if len(partition_keys) == 1 else partition_keys | |||
| with check_observed_deprecation(): | |||
| gb = data_df.groupby(partition_keys, dropna=False) | |||
| gb = data_df.groupby(partition_keys, dropna=False, observed=False) | |||
There was a problem hiding this comment.
A test was sporadically failing on Windows Python 3.11 due to check_observed_deprecation being flaky. Instead of catching the deprecation warning, I've specified observed=False instead (the current default) to avoid the warning altogether. Hope that's okay
jrbourbeau
changed the title
pandas=2.1.0
jrbourbeau
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-files