Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make preserve_index explicit in pyarrow_schema_dispatch #10501

Merged
merged 2 commits into from Sep 8, 2023
Merged

Make preserve_index explicit in pyarrow_schema_dispatch #10501

merged 2 commits into from Sep 8, 2023

Conversation

hendrikmakait
Copy link
Member

@hendrikmakait hendrikmakait commented Sep 8, 2023 •
edited

@hendrikmakait hendrikmakait mentioned this pull request Sep 8, 2023
Merged
3 tasks
rjzamora
rjzamora approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hendrikmakait ! Any chance we can address my other comment from #10500 here?

Otherwise, this is good.

@hendrikmakait
Copy link
Member Author

Thanks @hendrikmakait ! Any chance we can address my other comment from #10500 here?

Sure, we can do that here. Should we also clean up the **kwargs in other pyarrow-related dispatches in a follow-up?

@hendrikmakait hendrikmakait changed the title Recover test_pyarrow_conversion_dispatch Make preserve_index explicit in pyarrow_schema_dispatch Sep 8, 2023
@rjzamora
Copy link
Member

rjzamora commented Sep 8, 2023

Should we also clean up the **kwargs in other pyarrow-related dispatches in a follow-up?

I will be supportive of any cases where we can formalize the specific/necessary arguments in the pandas dispatch functions. However, I will understand if there are still arguments you are planning to experiment with in p2p.

@github-actions github-actions bot added the dispatch Related to `Dispatch` extension objects label Sep 8, 2023
rjzamora
rjzamora approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround @hendrikmakait !

@hendrikmakait hendrikmakait merged commit 0ceb9f3 into dask:main Sep 8, 2023
17 of 23 checks passed
@hendrikmakait hendrikmakait deleted the readd-test branch September 8, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjzamora rjzamora rjzamora approved these changes

Assignees
No one assigned
Labels
dataframe dispatch Related to `Dispatch` extension objects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hendrikmakait @rjzamora