Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unignore and fix deprecated freq aliases #10577

Merged
merged 20 commits into from Oct 19, 2023
Merged

unignore and fix deprecated freq aliases #10577

merged 20 commits into from Oct 19, 2023

Conversation

graingert
Copy link
Member

@graingert graingert commented Oct 19, 2023 •
edited

  • Tests added / passed
  • Passes pre-commit run --all-files

@github-actions github-actions bot added dataframe io documentation Improve or add to documentation labels Oct 19, 2023
@graingert graingert marked this pull request as ready for review October 19, 2023 13:45
@graingert graingert requested a review from phofl October 19, 2023 16:37
phofl
phofl reviewed Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to catch any warnings if a user specifies a deprecated freq in shift so that the warning isn’t raised for every partition?

fine as a follow up

@phofl phofl merged commit e06653c into dask:main Oct 19, 2023
24 checks passed
@phofl
Copy link
Collaborator

phofl commented Oct 19, 2023

Thx @graingert

@graingert graingert deleted the deprecated-time-aliases branch October 19, 2023 16:42
@crusaderky crusaderky mentioned this pull request Jan 22, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl left review comments

Assignees
No one assigned
Labels
dataframe documentation Improve or add to documentation io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@graingert @phofl