New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid shortcut in tasks shuffle that let to data loss #10763

Merged

hendrikmakait merged 2 commits into dask:main from phofl:data_loss

Jan 10, 2024

Collaborator

phofl commented Jan 9, 2024

Closes #xxxx
Tests added / passed
Passes pre-commit run --all-files

The shortcut let to inconsistent casting logic, which is problematic...


          Adjust shuffle tests for dask-expr

ff6c6c9

phofl requested a review from hendrikmakait

January 9, 2024 19:25


          Update

d067b45

hendrikmakait approved these changes

View reviewed changes

Member

hendrikmakait left a comment

Changes look good to me, thanks @phofl

hendrikmakait merged commit 7326b9d into dask:main

22 of 26 checks passed

phofl deleted the data_loss branch

January 10, 2024 11:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment