Remove deprecation warning about sort and split_out in groupby #10788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 3h 31m 23s ⏱️ + 6m 12s For more details on these failures, see this check. Results for commit 94ea041. ± Comparison against base commit efd8375. |
milesgranger
approved these changes
Jan 12, 2024
Comment on lines
3304
to
+3307
| # Warns for sort=None | ||
| with pytest.warns(FutureWarning, match="split_out>1"): | ||
| M.sum(ddf.groupby("x"), split_out=2) | ||
| with pytest.warns(None): | ||
| ddf.groupby("x").sum(split_out=2) | ||
| ddf.groupby("x").agg("sum", split_out=2) |
There was a problem hiding this comment.
Shall we remove the context entirely?
There was a problem hiding this comment.
That's a pattern we use in pandas when we want to show that it doesn't warn anymore, so I would like to keep It, it's a bit more explicit
There was a problem hiding this comment.
Okay, no issue with that. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesthis deprecation is counterintuitive for what we want to do in dask-expr to increase stability of computations on huge datasets, split_out should take precedence if sort is not given