Rename shuffle to shuffle_method in remaining methods #10797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 3h 39m 43s ⏱️ - 5m 21s For more details on these failures, see this check. Results for commit 965dab5. ± Comparison against base commit 91dd425. This pull request removes 16 and adds 42 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
phofl
reviewed
Jan 15, 2024
| @@ -209,9 +209,9 @@ def _determine_split_out_shuffle(shuffle, split_out): | |||
| return config.get("dataframe.shuffle.method", None) or "tasks" | |||
| else: | |||
| return False | |||
| if shuffle is True: | |||
| if shuffle_method is True: | |||
There was a problem hiding this comment.
That is something we want to deprecate as well, shuffle_method can only be a string the determines the shuffle method
split_out should be used to signal if you want to shuffle or not
There was a problem hiding this comment.
We can do this as a follow up though
There was a problem hiding this comment.
Ya, if it's good for you, would like to do this in a follow up.
phofl
reviewed
Jan 15, 2024
phofl
approved these changes
Jan 15, 2024
|
thx |
milesgranger
deleted the
milesgranger/10782-rename-shuffle-to-shuffle_method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesIs there suppose to be a deprecation period before this renaming?