Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed dtype arithmetics in numpy 2 #10831

Merged
merged 1 commit into from Jan 22, 2024
Merged

Conversation

crusaderky
Copy link
Collaborator

Part of #10593

Copy link
Contributor

github-actions bot commented Jan 18, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±0       15 suites  ±0   3h 25m 42s ⏱️ + 11m 40s
 12 912 tests ±0   11 983 ✅ ±0     929 💤 ±0  0 ❌ ±0 
159 984 runs  ±0  143 407 ✅ +1  16 577 💤  - 1  0 ❌ ±0 

Results for commit b3b423a. ± Comparison against base commit c0058eb.

♻️ This comment has been updated with latest results.

@crusaderky crusaderky force-pushed the np200_dtypes branch 2 times, most recently from ff4c80c to a6a7a7d Compare January 19, 2024 14:41
@crusaderky crusaderky changed the title Changed dtype arithmetics in numpy 2.x Changed dtype arithmetics in numpy 2 Jan 19, 2024
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @crusaderky!

@@ -51,6 +51,7 @@
stack,
store,
)
from dask.array.numpy_compat import _numpy_200
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OT: We may want to align naming conventions between things like _numpy_xyz and PANDAS_GE_XYZ.

@hendrikmakait hendrikmakait merged commit a46e664 into dask:main Jan 22, 2024
27 of 28 checks passed
@crusaderky crusaderky deleted the np200_dtypes branch January 22, 2024 10:13
@jakirkham jakirkham mentioned this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants