Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for dask-expr #10838

Merged
merged 7 commits into from Jan 30, 2024
Merged

Update tests for dask-expr #10838

merged 7 commits into from Jan 30, 2024

Conversation

phofl
Copy link
Collaborator

@phofl phofl commented Jan 19, 2024

  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

Some stuff started working since I added the skips and some other things are clarified now

Copy link
Contributor

github-actions bot commented Jan 19, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  +     1       15 suites  +1   3h 33m 29s ⏱️ + 43m 46s
 12 983 tests ±     0   12 051 ✅  -      3     929 💤 ±    0  3 ❌ +3 
160 174 runs  +12 791  143 594 ✅ +11 584  16 577 💤 +1 204  3 ❌ +3 

For more details on these failures, see this check.

Results for commit f4cf5ba. ± Comparison against base commit b897975.

♻️ This comment has been updated with latest results.

Co-authored-by: crusaderky <crusaderky@gmail.com>
Copy link
Collaborator

@crusaderky crusaderky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is very red now

@phofl phofl dismissed crusaderky’s stale review January 30, 2024 00:06

Rebasing fixed it, failures were not related

@phofl phofl merged commit 7e7cf3d into dask:main Jan 30, 2024
27 of 28 checks passed
@phofl phofl deleted the test_analysis branch January 30, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants