Adjust tests for median support in groupby-aggregate in dask-expr #10840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmakait
commented
Jan 19, 2024
| ) | ||
|
|
||
| specs = [ | ||
| {"b": {"c": "mean"}, "c": {"a": "max", "b": "min"}}, |
There was a problem hiding this comment.
pandas doesn't know what to do with these specs and from what I can tell, we never assert correctness on the result, so I've removed the tests and would consider this functionality not supported.
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 3h 27m 9s ⏱️ + 13m 7s Results for commit 26260f3. ± Comparison against base commit c0058eb. This pull request removes 2 tests. |
phofl
approved these changes
Jan 19, 2024
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-files