Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in test_graph_manipulation #10873

Merged
merged 2 commits into from Jan 29, 2024
Merged

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Jan 29, 2024

Fix regression introduced in #10865, appearing in dask_expr only.
The above PR changes tokenization of bound methods from

  • pickle of the whole instance plus method name

to

  • tokenization of the instance plus method name

and tokenization of generic objects does not attempt to pickle (by design).

@phofl
Copy link
Collaborator

phofl commented Jan 29, 2024

rebased after all the noise is gone in the dask-expr ci

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files       15 suites   3h 18m 46s ⏱️
 12 981 tests  12 048 ✅    929 💤 4 ❌
160 144 runs  143 562 ✅ 16 577 💤 5 ❌

For more details on these failures, see this check.

Results for commit 2c61fbd.

@phofl
Copy link
Collaborator

phofl commented Jan 29, 2024

only int and float hashing now left

@phofl phofl merged commit c37cc6e into dask:main Jan 29, 2024
25 of 28 checks passed
@crusaderky crusaderky deleted the nodecounter branch January 29, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants